Codefisher.org Forums : Toolbar Buttons 1.0 beta, testers wanted

Ok I said I would post an example of a really bad code that was in the extension.  It seams I wrote this in some mad fit a a couple of years ago.

function profileFolder() {
    var openProfileFolder = {
        open: function() {
            var directoryService = Components.classes['@mozilla.org/file/directory_service;1']
                                   .getService(Components.interfaces.nsIProperties);
            var profileFolder = directoryService.get('ProfD', Components.interfaces.nsIFile);
            this.runApplication(profileFolder.QueryInterface(Components.interfaces.nsILocalFile).path);
        },
        runApplication: function(aFolder) {
            var fileLocal = Components.classes["@mozilla.org/file/local;1"]
                            .getService(Components.interfaces.nsILocalFile);
            fileLocal.initWithPath(aFolder);
            fileLocal.launch();
        }
    }
    openProfileFolder.open();
}

If you can read the code you would see that I create a nsILocalFile and get the path from that, so I can pass it to another function to create a new nsILocalFile for no reason at all.  I could have just written this.

function profileFolder() {
    Components.classes['@mozilla.org/file/directory_service;1']
        .getService(Components.interfaces.nsIProperties)
        .get('ProfD', Components.interfaces.nsIFile)
        .QueryInterface(Components.interfaces.nsILocalFile).launch();
}

As stated, some buttons are missing.

I will re-add all the buttons into the new version, however I may not package them all into the release I put on addons.mozilla.org and the extension's home page.

No, unfortunately not long after staring this a few other things come up that needed attention, and now UNI has started again so it is going to be a little slow.

>>I am changing all the icons.  In future they will all be from my Pastel SVG icon set ...
May I suggest that you add a feature to use/import icon sets developed by others?  People have different tastes, you know.  I, personally, like the Black X icon set.  Currently, I'm experimenting with your current icon set, changing it to make it blend in better with the Black X motif.

Hey if you ever need beta testing help for any of your extensions, I'll gladly help (of course) for Fx, Tbird, and if need be, I can install Sunbird again. If you don't have anyone, I'll install Flock also.

As for Toolbar Buttons, it would be cool if you would pre-configure several toolbars loaded with all of your Toolbar Buttons.
It would save a lot of time from having to add and test each one individually.

I try the beta in SeaMonkey, but it needs some modification. Therefor I use 7zip. That works with files in the xpi, but doesn't with tbutton.jar. There I get an error on repacking. I need to unpack it first and pack it with 7zip. Seems you've packed it with a special system.

7zip error is: Unknown Error

But I must say, there appears another notification which I never read before:

Error: Duplicate filename
skin\16\plugin.png
skin\16\plugin.png

And indeed, 7zip shows two identical files plugin.png (in \16\ and in \24\!), whereas FreeCommander shows only one.

Any update on the new version?

Great extension!  I just upgraded to TB3.1, and although TB claims it doesn't work with 3.1, it does.  (I'm running Nightly Tester Tools and MR Tech Toolkit.)  It would be great if you could add a button "Mark All Read" to work in usenet newsgroups.  There is an extension that does this all by itself, but it would be great to have in your giant collection.  :-)

I make heavy use of your "All Threads," "Threads w/ Unread," "Watched Threads w/ Unread," "Ignored Threads," etc.  Although my default view is collapsed, your buttons expand the threads.  It's easy enough to correct using "\", but it would be especially nice on a small notebook screen to have the threads collapsed by default.

Thanks again for a great addon!  :-)